Open
Conversation
This allows removing the Metadata associated type from BackendTypes.
Collaborator
|
Some changes occurred in compiler/rustc_codegen_gcc |
rustbot
added
A-LLVM
Collaborator
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
In Cranelift the regular Type enum can't represent function signatures. Function pointers are represented as plain pointer sized integer.
bjorn3
force-pushed
the
cg_ssa_cleanups
branch
2 times, most recently
from
1165ac2 to
79d3b8e
Compare
This comment has been minimized.
This comment has been minimized.
In Cranelift a Value can't hold arbitrarily sized values.
bjorn3
force-pushed
the
cg_ssa_cleanups
branch
from
79d3b8e to
df4b228
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These should help a bit with using cg_ssa in cg_clif at some point in the future.